Add serialization support to more gates#6479
Conversation
NoureldinYosri
requested review from
a team,
cduck,
verult,
vtomole and
wcourtney
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6479 +/- ##
==========================================
- Coverage 97.76% 97.75% -0.02%
==========================================
Files 1105 1105
Lines 94963 94959 -4
==========================================
- Hits 92837 92823 -14
- Misses 2126 2136 +10 ☔ View full report in Codecov by Sentry. |
|
You might already thinking about this as a next step, but reminder to add to the device gateset as well. Happy to talk through the required changes if needed. |
| message CliffordTableau { | ||
| optional int32 num_qubits = 1; | ||
| optional int32 initial_state = 2; | ||
| optional bytes rs = 3; |
There was a problem hiding this comment.
Same comment as before w.r.t. numpy serialization. In this case, I think it might be okay, but we should at least document it.
There was a problem hiding this comment.
I changed the serialization to be independent of numpy
|
@verult thanks for pointing that out. that will be a seprate PR if we need it. |
This PR adds serializatoin support to - IdentityGate => fixes quantumlib#4833 - HPowGate => allows sending circuits with cirq.H to backend - changes the handling of SingleQubitCliffordGate from automatic conversion to PhasedXZGate to have its own proto (originally proposed in quantumlib#6418)
4 participants
This PR adds serializatoin support to
supersedes #6458
cc: @dstrain115 @maffoo